Fix findinstances quote handling #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2018 14:50
This allows subclasses to override how the command line is split. This is necessary for commands that need to preserve quotes.
kastiglione
force-pushed
the
findinstances-quote-handling
branch
from
96b753d to
07fb3d2
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chisel defaults to using
shlexfor splitting the command line. This is useful for arguments that contain spaces, the command line can be written with quotes around those arguments. But this behavior is a problem for for arguments using literal quotes, which can happen withfindinstances. For examplefindinstances NSDictionary any @allKeys == "someKey".This change allows commands to override command line splitting, for the cases where
shlexis not desired.