add ppath command #72
Conversation
Print application's 'Documents' directory path.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please # at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
|
||
| class FBPrintApplicationDocumentsPath(fb.FBCommand): | ||
| def name(self): | ||
| return 'ppath' |
There was a problem hiding this comment.
I feel like pdocspath might be a better command here, even if it is a bit verbose. Luckily the prefix matching will then allow pdocs to work as well. Thoughts?
There was a problem hiding this comment.
have thought about this before. It seems to me the word docs path is a little ambiguous, maybe docs dir path is better but too long. Here use ppath is just easy to type in. will change to the name suggested.
There was a problem hiding this comment.
Thought: have ppath capable of printing other paths other than docs, and have it take an argument to specify which specific path. Otherwise, perhaps ppath can just print the app root, and then it's easy for users to append Documents or any other subpath.
| return "Print application's 'Documents' directory path." | ||
|
|
||
| def run(self, arguments, options): | ||
| lldb.debugger.HandleCommand('po [NSSearchPathForDirectoriesInDomains(9, 1, YES) lastObject]') # NSDocumentDirectory == 9 NSUserDomainMask == 1 |
There was a problem hiding this comment.
In other parts of Chisel, in addition to printing a value, we've copied it to the pasteboard. Would you mind adding that here?
|
@dopcn What do you think about having option flags to allow the desired directory to be opened in Terminal, or maybe Finder as well? For example |
not fully tested yet
|
|
||
| def run(self, arguments, options): | ||
| if options.open: | ||
| path = fb.evaluateExpressionValue('(NSString *)[NSSearchPathForDirectoriesInDomains(9, 1, YES) lastObject]') |
There was a problem hiding this comment.
Can you make constants for these numbers?
There was a problem hiding this comment.
This could use evaluateObjectExpression() instead of evaluateExpressionValue(), which would make the NSString cast unnecessary.
There was a problem hiding this comment.
@kastiglione hi I tried evaluateObjectExpression() and evaluateExpression() but only get pointer value instead of string value so I keep using evaluateExpressionValue() and split the string output in the new implementation. Am I missing something?
|
@dopcn What do you think of the comments I made? |
|
@kastiglione sorry, back and working on it now... |
|
Update copy to the pasteboard before print |
| NSUserDomainMask = '1' | ||
| path = fb.evaluateExpressionValue('(NSString*)[NSSearchPathForDirectoriesInDomains(' + NSDocumentDirectory + ', ' + NSUserDomainMask + ', YES) lastObject]') | ||
| pathString = '{}'.format(path).split('"')[1] | ||
| cmd = 'echo {} | tr -d "\n" | pbcopy'.format(pathString) |
There was a problem hiding this comment.
This could be echo -n to avoid the tr piece.
There was a problem hiding this comment.
I don't know why echo -n just doesn't work as os.system()'s parameter. The -n will be taken as part of pathString and copied into pasteboard
There was a problem hiding this comment.
Seems /bin/sh doesn't handle -n like bash and zsh do. Oh well. Thanks for trying.
|
Thanks @dopcn, I'm happy to accept this. Before that, can you merge from |
|
Thanks @dopcn! |
Print application's 'Documents' directory path.