Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Loosen react/jsx-handler-names rule #156

Closed
mxstbr opened this issue Jul 24, 2016 · 0 comments · May be fixed by marcusrc/create-react-app#1
Closed

Loosen react/jsx-handler-names rule #156

mxstbr opened this issue Jul 24, 2016 · 0 comments · May be fixed by marcusrc/create-react-app#1
Labels
contributions: up for grabs! issue: bug

Comments

@mxstbr
Copy link
Contributor

mxstbr commented Jul 24, 2016

This is a very stylistic rule that I don't think we should be warning about. I have a component like this:

<form onSubmit={this.fetchData} />

and I'm getting warnings in the console saying:

Handler function for onSubmit prop key must begin with 'handle'

We should be disabling this, because I think the above is perfectly fine even if not called "handleSubmit".
@mxstbr mxstbr mentioned this issue Jul 24, 2016
Merged
mxstbr added a commit that referenced this issue Jul 24, 2016
@mxstbr
Disable jsx-handler-name eslint rule
3a707ea 
Ref #156

Not sure if we can simply delete the line and that'll disable it, so I
went with setting it to 0. Let me know!
gaearon pushed a commit that referenced this issue Jul 24, 2016
@mxstbr @gaearon
Disable jsx-handler-name eslint rule (#157)
662fdb7 
Ref #156

Not sure if we can simply delete the line and that'll disable it, so I
went with setting it to 0. Let me know!
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
contributions: up for grabs! issue: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade tmp from 0.0.31 to 0.2.1 marcusrc/create-react-app
1 participant
@mxstbr