-
-
Notifications
You must be signed in to change notification settings - Fork 27k
fix: remove generating .eslintcache #10177
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: remove generating .eslintcache #10177
Conversation
fixes facebook#10161 No need to generate eslint cache due to performance boost gained in eslint-webpack-plugin 2.4.1
I'm probably missing some context here, but what does disable the cache improve? |
The cache was enabled in #9911 in order to improve recompilation time slowness. It turned out that after enabling it - file However, |
This fix doesn't work please. And this is slowing down development for us rookies and it's giving me and my team no joy. A lot of data in terms of frustrations going on web now. I really don't see the need for caching in development and as a noob.. |
@ianschmitz reopening this pull-request due to an increasing amount of complaints regarding having eslint caching enabled (#10161) |
Cache enabled causes serving old data: #10301 |
Hey hope this makes the next release. I keep running into the above issue where .eslintcache gets stale and the dev server needs to be restarted. It's a bit of a killer. |
This has been addressed in #10177. The cache directory has been moved into node_modules. |
fixes #10161
No need to generate eslint cache due to performance boost
gained in eslint-webpack-plugin 2.4.1
Pull-request where eslint cache generation was enabled: #9911
Following discussion about performance boost: #9886
Version of eslint-webpack-plugin with recompiling performance improvements: https://github.com/webpack-contrib/eslint-webpack-plugin/releases/tag/v2.4.1