Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update PostCSS packages #10456

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Update PostCSS packages #10456

merged 2 commits into from
Mar 17, 2021

Conversation

raix
Copy link
Contributor

@raix raix commented Jan 27, 2021

Update postcss-loader@4.04 postcss-flexbugs-fixes@5.0.0 postcss-normalize@9.0.0

Changes:

  • indent is no longer needed accordingly to changelog
  • options from Object to Array syntax
  • postcss is now a peer dependency

ref: https://github.com/webpack-contrib/postcss-loader/blob/master/CHANGELOG.md#400-2020-09-07

Part of making way for Webpack 5 #9994

Reference to initial pr #10003 reverted in #10216

@raix
Copy link
Contributor Author

raix commented Jan 27, 2021

@ianschmitz & @ai I've created a new pr for updating postcss to v8

I do see multiple versions of postcss but I don't think it will be solved until all plugins are updated to the new plugin format (without a postcss dependency?)

postcss@7.0.21

  • resolve-url-loader

postcss@7.0.35

postcss@8.2.4 (we could stay at 8.1.9)

  • react-scripts

postcss@8.1.9

  • postcss-safe-parser

regarding postcss-browser-comments I could not find any open issues regarding updating to postcss8

In our private build setup we also had to add autoprefixer as a dependency - but for now the CRA build haven't complained about it.

@raix raix mentioned this pull request Jan 27, 2021
25 tasks
@ai
Copy link
Contributor

ai commented Jan 27, 2021

LGTM

I do see multiple versions of postcss but I don't think it will be solved until all plugins are updated to the new plugin format (without a postcss dependency?)

Yeap, for the transition period we will still see PostCSS in deep dependencies.

@msalahz
Copy link

msalahz commented Mar 17, 2021

Any updates on this?

@ianschmitz ianschmitz added this to the 4.0.4 milestone Mar 17, 2021
@ianschmitz ianschmitz merged commit 7b56cf7 into facebook:master Mar 17, 2021
@ianschmitz ianschmitz changed the title Wp5 prepare update postcss part 2 Update PostCSS packages Mar 17, 2021
@ianschmitz
Copy link
Contributor

Many thanks @raix. Sorry about the long delays

@raix
Copy link
Contributor Author

raix commented Mar 17, 2021

No worries @ianschmitz :)

@harryzcy harryzcy mentioned this pull request Mar 17, 2021
@msalahz
Copy link

msalahz commented Mar 17, 2021

When we should expect this to be released?

@radiosilence
Copy link

radiosilence commented Apr 28, 2021

@raix does postcss-normalize 9 actually support postcss 8?

There's currently an active PR on master suggesting that it does not:

csstools/postcss-normalize#53

akxcv pushed a commit to akxcv/create-react-app that referenced this pull request Apr 28, 2021
@raix
Copy link
Contributor Author

raix commented Apr 30, 2021

@radiosilence Thanks it's been unclear as postcss should work with older plugins - we should bump normalize to 10.0.0

@radiosilence
Copy link

Yep, postcss-normalize 10.0.0 has been released so we should indeed bump it

@Bluefitdev
Copy link

Added the PR #10946

wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants