-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
allow CORS on webpack-dev-server #11325
allow CORS on webpack-dev-server #11325
Conversation
maybe you can set
|
Yes, this is a working workaround, one could also use craco to do this but we are working on making create-react-app module-federation ready out of the box. |
@hasanayan agree we might need this (just looking at the module federation examples) |
I feel ya :) will update the PR soon |
@raix done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this change @iansu, as it's only the dev server anyway. WDYT?
Thanks! |
working with module federation locally in development mode requires CORS. This PR enables that.