Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not break lines #1140

Closed
wants to merge 1 commit into from
Closed

Do not break lines #1140

wants to merge 1 commit into from

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Dec 3, 2016

Resolves #1112 (as part of red box <-> syntax error parity)
(enables overflow / scroll)


@gaearon
Copy link
Contributor

gaearon commented Dec 3, 2016

Is this always better? I’d like to redesign the screen to be consistent but I’m hoping @nicinabox could give us some pointers here.

@Timer
Copy link
Contributor Author

Timer commented Dec 3, 2016

@gaearon the screen was already redesigned in the redbox branch (color palette); this is a screenshot from the master branch

And as for better, I'm not sure what other way to really accomplish this besides enabling overflow, do you have any suggestions?

@Timer
Copy link
Contributor Author

Timer commented Dec 4, 2016

Actually, we might want to let certain things wrap and others not. We can let someone else propose a solution or wait to see what pans out best in red box.

@Timer Timer closed this Dec 4, 2016
@gaearon
Copy link
Contributor

gaearon commented Dec 5, 2016

the screen was already redesigned in the redbox branch (color palette)

Oh, I meant not just color palette but making it more consistent in general. Right now it looks too much like a terminal—I was wondering if we could make it more dialog-y to match the error dialog.

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants