-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove dependency pinning #11474
Remove dependency pinning #11474
Conversation
@mrmckeb can you take a quick look and check if there are any other pinned dependencies we want to unpin? |
This is effectively treating the symptom and not the cause, the dependency check makes the flawed assumption that the dependencies of |
@iansu what do you think about unpinning Webpack too? Storybook is now ahead of us, and that's now flagged in the pre-flight check. Long-term we need to solve this problem. |
d56d751
to
05641cf
Compare
0b7a94a
to
aa93caa
Compare
@mrmckeb Unpinning webpack sounds a bit scary but I think we should aim to unpin everything and see how that goes during the v5 alpha process. |
This PR unpins
babel-loader
, which has been causing issues when using Create React App with Storybook.We don't expect this to have any negative side-effects, and users can pin this themselves if needed via Yarn's
resolutions
or npm's upcomingoverrides
feature.Related Storybook issue: storybookjs/storybook#5183.