Skip to content

[WIP] Fix integration test teardown / cleanup and missing yarn installation #11686

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 30 commits into from
Dec 1, 2021
Merged

[WIP] Fix integration test teardown / cleanup and missing yarn installation #11686

merged 30 commits into from
Dec 1, 2021

Conversation

raix
Copy link
Contributor

@raix raix commented Nov 27, 2021

Fix tests and update execa:

  • To avoid flakyness due to race conditions: use sync version of remove letting beforeEach and afterAll
  • Update execa from v1 to v5 (v6 requires esm so downgraded to v5 for now)
  • Added test to make sure yarn is installed (making it easier to debug next time)
  • Added npm i -g yarn in github action for integration tests
  • Increased the timeout for now in yarn integration test
  • Improve run create-react-app output logging output and exit code in github action groups for better insights
  • Defer jest test result waiting for stdio to flush

Findings:

  • Sometimes yarn connectivity failes after x amount of retries

cc @iansu & @mrmckeb (We should likely squash this one if merging...)

@raix raix requested a review from iansu November 27, 2021 17:09
@raix raix changed the title Fix integration test teardown / cleanup Fix integration test teardown / cleanup and missing yarn installation Nov 27, 2021
@raix raix changed the title Fix integration test teardown / cleanup and missing yarn installation [WIP] Fix integration test teardown / cleanup and missing yarn installation Nov 28, 2021
Copy link

@Arj031 Arj031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants