Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable gh-page setup instruction if scripts.deploy has been added #1222

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

n3tr
Copy link
Contributor

@n3tr n3tr commented Dec 9, 2016

resolve #1221

Disable github page setup instruction if scripts.deploy has been added to package.json

No deploy script

> yarn run build
The build folder is ready to be deployed.
To publish it at http://myname.github.io/myapp, run:

  yarn add --dev gh-pages

Add the following script in your package.json.

    // ...
    "scripts": {
      // ...
      "deploy": "npm run build&&gh-pages -d build"
    }

Then run:

  yarn run deploy

✨  Done in 7.45s.

after added deploy

The project was built assuming it is hosted at /myapp/.
You can control this with the homepage field in your package.json.

The build folder is ready to be deployed.
To publish it at http://myname.github.io/myapp, run:

  yarn run deploy

✨  Done in 7.08s.

@gaearon
Copy link
Contributor

gaearon commented Dec 9, 2016

LGTM!

@gaearon gaearon mentioned this pull request Dec 11, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable "deploy" hint if "deploy" exists in package.json "scripts"
3 participants