Skip to content

backup and restore .npmignore #1462

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed

Conversation

tuchk4
Copy link
Contributor

@tuchk4 tuchk4 commented Jan 27, 2017

Each time after tests - there is deleted .npmignore and git status is not clean.

Backup and restore .npmignore as well as packgae.json.

@EnoahNetzach could you please check it? Do we really need it?
If yes - I am not sure about where should be code to restore.
Now at cleanup function but maybe it could be placed earlier during script execution

@wtgtybhertgeghgtwtg
Copy link
Contributor

files in package.json wouldn't be a solution?

@tuchk4
Copy link
Contributor Author

tuchk4 commented Jan 30, 2017

@wtgtybhertgeghgtwtg files will not help. I mean it could be implemented via files instead of .npmignore but anyway it should be backed up and restored

@EnoahNetzach could you please check this?

btw. Travis fails because of this #1461

@EnoahNetzach
Copy link
Contributor

@tuchk4 I don't sincerely know, I personally run tests on a docker container..
If this is the problem here, I'm going to PR the docker runner soon.

@tuchk4
Copy link
Contributor Author

tuchk4 commented Jan 30, 2017

@EnoahNetzach the problem is that after running test git directory is not clean - deleted .npmignore (e2e-kitchensink.sh#L97) that is under git version control.

@tuchk4
Copy link
Contributor Author

tuchk4 commented Jan 30, 2017

Seems this PR is not needed after E2e jsdom fix #1470 was merged becasue .npmignore is not removing now

@tuchk4 tuchk4 closed this Jan 30, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants