Skip to content

Add custom eslint formatter #2136

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Add custom eslint formatter #2136

wants to merge 1 commit into from

Conversation

sidoshi
Copy link
Contributor

@sidoshi sidoshi commented May 12, 2017

Replaces hacky code to format eslint errors by using custom loader.

I built this formatter on top of the default stylish formatter.
It omits warnings if there are any eslint errors as required in #2120 and errors and warnings looks the same as earlier.

Closes #2121

@gaearon
Copy link
Contributor

gaearon commented May 12, 2017

Any reason you closed?

@sidoshi
Copy link
Contributor Author

sidoshi commented May 12, 2017

While reformatting my code after testing I used absolute require in require ('formatter') instead of relative, like require('./formatter'). Trying to fix it without opening another pull request.

@gaearon
Copy link
Contributor

gaearon commented May 12, 2017

We probably don't want this formatter to live in react-scripts because we don't want to keep it in user code after ejecting. Let's move it to react-dev-utils?

@sidoshi
Copy link
Contributor Author

sidoshi commented May 12, 2017

Sure.

@sidoshi
Copy link
Contributor Author

sidoshi commented May 12, 2017

I have pushed to the branch I have sent pull request from. But the changes doesn't seem to be updated. Is it because I have closed the PR?
Sorry for the inconvenience, I am learning how this things work.

@gaearon
Copy link
Contributor

gaearon commented May 12, 2017

Yea, could you push to a new branch and open another PR please?

@sidoshi
Copy link
Contributor Author

sidoshi commented May 12, 2017

Okay doing it. Thanks.

@sidoshi
Copy link
Contributor Author

sidoshi commented May 12, 2017

See #2138

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants