Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Run npm 5 on CI #2792

Closed
wants to merge 5 commits into from
Closed

Run npm 5 on CI #2792

wants to merge 5 commits into from

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jul 14, 2017

I hope 5.3.x fixed issues and we can try using it.

@gaearon
Copy link
Contributor Author

gaearon commented Jul 14, 2017 

Creating an optimized production build...
Failed to compile.
./src/index.js
  Line 0:  Cannot find module 'babel-code-frame'

😞

@viankakrisna
Copy link
Contributor

@gaearon 5.4.0 is released last week, worth a try?

@gaearon
Copy link
Contributor Author

gaearon commented Aug 29, 2017

@viankakrisna Would you like to send a PR?

@viankakrisna viankakrisna mentioned this pull request Aug 29, 2017
Merged
@Timer Timer closed this Sep 10, 2017
@Timer Timer deleted the gaearon-patch-18 branch September 10, 2017 05:03
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @viankakrisna @Timer @facebook-github-bot