Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add index.html file #3

Merged
merged 2 commits into from
Jul 17, 2016
Merged

Add index.html file #3

merged 2 commits into from
Jul 17, 2016

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Jul 17, 2016

Adds an index.html to the users source folder that's used as a template for HTMLWebpackPlugin. This means users can go in and add static assets to the HTML file, avoids a lot of confusion.

First commit implements it in the src directory, second commit moves it to the root folder as per the discussion with Dan.

@gaearon gaearon merged commit 3a003be into facebook:master Jul 17, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 17, 2016

Thanks!

@gaearon gaearon deleted the html-file branch July 17, 2016 18:40
@vjeux
Copy link
Contributor

vjeux commented Jul 17, 2016

nit: you can use squash now which makes the history cleaner :)

@gaearon
Copy link
Contributor

gaearon commented Jul 17, 2016

I will! (Forgot it’s not the default—I think it is in React repo..)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants