normalize the e2e behavior for npm link in npm 5 and below #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viankakrisna
changed the title
viankakrisna
force-pushed
the
npm5link
branch
from
6161027 to
7d5f685
Compare
viankakrisna
changed the title
¯\(ツ)/¯ |
|
found a related issue npm/npm#16970 |
|
closing this as it seems that 5.4.1 is not stable enough for npm link (or need us to refactor e2e for it to work) |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in #3026 made some build fails in node 8 (success in #3104 and #3026 , failed in #2755 because of misssing dependencies). probably because npm link behavior is changed in npm 5 http://codetunnel.io/npm-5-changes-to-npm-link/
this PR tries to investigate how to normalize the npm link behavior for e2e in npm 5 and below