-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
use uglifyjs-webpack-plugin v1 #3618
use uglifyjs-webpack-plugin v1 #3618
Conversation
Oops, accidentally merged this to master. You can find this in |
Is there any chance of this getting into a 1.1.2 (or similar) release? This will fix a lot of the minifying problems. |
No, this will not be released in a 1.1.2 release. Sorry! This is not a minifying problem, but as that link explains it's a problem with the libraries you're importing. |
as quoted by the readme https://github.com/webpack-contrib/uglifyjs-webpack-plugin:
The v1 is released on October, so I think it's mature enough to switch to v1 in CRA? or do we want to wait for webpack 4?
Pro:
This allows us to use uglify-es and access to parallel and cache options. Hence improving our build speed.
Con:
I haven't test it yet, but maybe this will break our parsing of uglify error #2650