-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Suggest reactstrap
instead of react-bootstrap
#4703
Conversation
you don't have to create new PRs when revising. you can just push a commit to your branch, and it should automatically reflect here. |
@bugzpodder But i had to change pr branch from master to next .. |
💯 |
This PR needs a little clean up consider to follow this https://github.com/facebook/create-react-app/pull/4314/files This is by the creators of Reactstrap |
What's the difference aside from gist's contents? |
@bugzpodder You don't need to specify the version 4 like I think reason the 4 is there Go ahead and copy that PR it should take care of all issues |
We want to be intentional about the version. The @4 will stay; people still actively use 3 so being explicit never hurts for clarity. |
@Timer Sure, you're the boss here, I still think you shouldn't have to specify a version number. |
* Suggest `reactstrap` instead of `react-bootstrap` * Update README.md
I thought it would be great to recommend reactstrap for now, instead of react-bootstrap. :)