Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lists loader-utils in the dependencies #5134

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Sep 27, 2018

The loader-utils package is defined in getCSSModuleLocalIdent (source), but isn't declared in the package.json. I took the version used by react-scripts.

@Timer Timer added this to the 2.0.0 milestone Sep 27, 2018
@Timer
Copy link
Contributor

Timer commented Sep 27, 2018

Nice catch! I'm sure we'll find a lot of these once we switch to Yarn PnP.
/cc @gaearon

edit: oh wait, looking at who sent this PR, this was probably found with Yarn PnP 😆

Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@Timer
Copy link
Contributor

Timer commented Sep 27, 2018

Do we need this in react-scripts? I'm guessing you can remove it there, please.

@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2018

I guess we forgot to move it

@Timer Timer merged commit ed93715 into facebook:master Sep 27, 2018
@Timer
Copy link
Contributor

Timer commented Sep 27, 2018

Followup 6510a27

@arcanis arcanis mentioned this pull request Sep 27, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants