Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test class properties #5183

Merged
merged 9 commits into from
Oct 1, 2018
Merged

Test class properties #5183

merged 9 commits into from
Oct 1, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Oct 1, 2018

Before #5182:

 FAIL  fixtures/smoke/issue-5176-flow-class-properties/index.test.js (128.315s)
  ● issue #5176 (flow class properties interaction) › passes tests
    Command failed: ./node_modules/.bin/react-scripts test --env node --ci
    FAIL src/App.test.js
      ✕ creates instance without (7ms)
      ● creates instance without
        TypeError: Cannot read property 'bind' of undefined
          1 | class App {
          2 |   constructor() {
        > 3 |     this.foo = this.foo.bind(this);
            |                         ^
          4 |   }
          5 |   foo: void => void;
          6 |   foo() {

After:

 PASS  fixtures/smoke/issue-5176-flow-class-properties/index.test.js (203.468s)

Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write up how to use all this infra somewhere?

@Timer
Copy link
Contributor Author

Timer commented Oct 1, 2018

Sure. I'll clean it up a bit and toss a guide on usage in CONTRIBUTING.md.

@Timer Timer merged commit 02b8c35 into facebook:master Oct 1, 2018
@Timer Timer deleted the test-class-properties branch October 1, 2018 00:26
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants