Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Still emit runtime chunk #5184

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Still emit runtime chunk #5184

merged 1 commit into from
Oct 1, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Oct 1, 2018 •
edited
Loading

This emits the runtime chunk and puts it in the asset-manifest.json.
It is still inlined into index.html and is not required via <script src="..." />.

Fixes #5172
Fixes #5144

@Timer Timer added this to the 2.0.0 milestone Oct 1, 2018
@Timer Timer requested a review from gaearon October 1, 2018 00:42
gaearon
gaearon approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's neat. I forgot we have control over this.

@Timer Timer mentioned this pull request Oct 1, 2018
Closed
@Timer Timer merged commit 789933c into facebook:master Oct 1, 2018
@Timer Timer deleted the emit-runtime branch October 1, 2018 00:58
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @gaearon @facebook-github-bot