Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds a version check when using --use-pnp #5269

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Oct 3, 2018

This PR ensures that users of --use-pnp are using at least the 1.12 release, which is the first one supported by create-react-app.

Ref #5255

@jimthedev
Copy link

This won't work when they are using a nightly version of yarn since semver will throw.

https://repl.it/@jimthedev/IgnorantOutgoingActivemovie

You can handle this in the catch by parsing it a second time after popping off everything after the '.' in the nightly yarn version.

@jimthedev
Copy link

Looks like semver.gte('1.13.0-20181006.0202', '1.12.0', { loose:true }) might do it.

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants