Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable Terser inline 3 option #5281

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Oct 3, 2018

Fixes #5250

@Timer Timer added this to the 2.0.4 milestone Oct 3, 2018
@Timer Timer merged commit f166144 into facebook:master Oct 3, 2018
@Timer Timer deleted the disable-inline-3 branch October 3, 2018 19:43
@kzc
Copy link

kzc commented Oct 4, 2018

@Timer Since we're in this file, this mapbox webworkify typeof global bug:

// Disabled because of an issue with Uglify breaking seemingly valid code:
// https://github.com/facebook/create-react-app/issues/2376
// Pending further investigation:
// https://github.com/mishoo/UglifyJS2/issues/2011
comparisons: false,

was recently fixed in mapbox/mapbox-gl-js#6956

so the comparisons: false workaround is no longer needed for the latest versions of mapbox.

If you wish to support older versions of mapbox I'd recommend this more constrained workaround and better description:

angular/angular-cli@ef52675

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants