Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update path to serviceWorker.js in graphical folder structure #5371

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Update path to serviceWorker.js in graphical folder structure #5371

merged 1 commit into from
Oct 9, 2018

Conversation

jonscottclark
Copy link
Contributor

Simply updating the filename displayed to match what gets generated in 2.x.x

@iansu
Copy link
Contributor

iansu commented Oct 9, 2018

Have you searched to make sure these are the only two references to the old filename?

@jonscottclark
Copy link
Contributor Author

@iansu Yep, searched the cloned project in VS Code, checked over the results, and that's how I made the changes.

@jonscottclark
Copy link
Contributor Author

@iansu I should mention that there are occurrences of the old string in the changelog, the most recent of which is from 1.0.15 (October 30, 2017), so I assumed that didn't have to change.

@iansu iansu added this to the 2.0.5 milestone Oct 9, 2018
@iansu iansu merged commit 04735de into facebook:master Oct 9, 2018
@iansu
Copy link
Contributor

iansu commented Oct 9, 2018

Thanks!

@jonscottclark jonscottclark deleted the bugfix/readme-folder-structure branch October 10, 2018 14:44
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants