add tests for named-asset-imports plugin #5575
Conversation
|
This is great. I suggested a few changes and we'll need to get this passing on CI. |
…med-asset-plugin-tests
|
Tests have been updated. please let me know if you think we need more tests to cover more cases. Thanks |
|
Can we make sure these tests run as part of e2e? Just add it somewhere in |
| snapshot: false, | ||
| tests: { | ||
| defaultImport: { | ||
| code: 'import logo from "logo";', |
There was a problem hiding this comment.
Is there a reason these don't include the file name? Why not import logo from 'logo.svg';?
There was a problem hiding this comment.
The first 3 tests are testing cases when file extension does NOT match to plugin config (.svg in here),
and rest can cover tests when imported file extension matches to config
There was a problem hiding this comment.
svgDefaultImport covers default import of logo.svg
| @@ -118,6 +118,10 @@ cd packages/react-dev-utils/ | |||
| yarn test | |||
| cd ../.. | |||
|
|
|||
| cd packages/babel-plugin-named-asset-import/ | |||
There was a problem hiding this comment.
@Timer tests run as part of e2e
|
Thanks! |
Some automation tests added to test named-asset-imports plugin
Hot to run
OR