-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Include absoluteRuntime in babel preset docs #5847
Conversation
Documented babel-preset-react-app absoluteRuntime option
Thanks for this @iddan. Out of interest, what was the motivation for this PR? Was it an issue you faced yourself? And if so, why did you need to modify this setting? Thanks! |
If I remember correctly I stumbled upon it while trying to integrate Storybook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iddan, two comments here - but looks good.
By the way, Storybook now works with create-react-app (including TypeScript and CSS modules (Sass included) without a custom config.
I think this should be merged! It turns out that this plugin was causing the See: webpack/webpack#1155 and webpack/webpack#7179 |
Co-Authored-By: Brody McKee <mrmckeb@users.noreply.github.com>
Why was this not merged? |
Sorry this got missed. Thanks @iddan. |
Documented babel-preset-react-app absoluteRuntime option