-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[docs] Warn/clarify that env vars are NOT "SECRET" #6062
Conversation
Lines 26-30 (in my branch, pasted below) need to be adjusted as well, but I would like some clarity. I'm uncertain why there are such deliberate assertions that secrets can be used in env vars, am I misunderstanding something? I would also like some insight into when not to include env vars in version control.
|
I think the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few tiny comments, all in all I think this is a pretty good change and something that seems to trip many new CRA users (including people in my team).
Thanks for the review @petetnt, incorporated your suggestions. Still unsure about this line:
|
I think that the whole sentence could be removed, it doesn't offer much / anything that wasn't explained in the document beforehand. |
@petetnt I actually like the first part of the sentence (up until "deployed"), but I'm still curious as to why version control was brought up.
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
I’m still waiting for a response from the maintainers, so this should be kept open. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @JBallin. Just one small tweak and I think we should be good.
Fixes #5676 Co-Authored-By: Ian Schmitz <ianschmitz@gmail.com>
Thanks @JBallin! |
Thank YOU @ianschmitz, I'm so excited to have made my first contribution to CRA! Unfortunately, an unintended change snuck through. I've opened a PR (#6386) to fix it. Sorry about that. |
Fixes #5676