Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove outdated docs for setting up eslint in editor #6084

Merged
merged 1 commit into from
Dec 24, 2018
Merged

Remove outdated docs for setting up eslint in editor #6084

merged 1 commit into from
Dec 24, 2018

Conversation

LukasWerfel
Copy link
Contributor

@LukasWerfel LukasWerfel commented Dec 22, 2018

My first, naive approach was just to remove that section. If we should rather modify it or leave it for older versions, let me know!

closes: #6083

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please # at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@attaradev attaradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they will appreciate if you don't link to the babel docs, but rather add the steps to follow to add the feature

@Timer
Copy link
Contributor

Timer commented Dec 23, 2018

Yeah, let's modify instead of remove because this is only for newly created projects. People who are migrating to newer version or accidentally remove the section might still need these docs.

@LukasWerfel
Copy link
Contributor Author

LukasWerfel commented Dec 24, 2018

@Timer Updated it. I am not a native speaker so it very well might have some grammatical errors or just wont sound natural. Let me know what you think!

Add a note that it will work in IDE with 2.0.3 and later
@Timer
Copy link
Contributor

Timer commented Dec 24, 2018

Nope, this is good. Thanks!

@Timer Timer merged commit 42a1b5a into facebook:master Dec 24, 2018
@Timer Timer added this to the 2.1.3 milestone Dec 24, 2018
@lock lock bot locked and limited conversation to collaborators Jan 8, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated docs with regards to eslint
4 participants