Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bump eslint-plugin-react version and update webpack config #6132

Merged
merged 3 commits into from
Jan 6, 2019
Merged

Bump eslint-plugin-react version and update webpack config #6132

merged 3 commits into from
Jan 6, 2019

Conversation

ianschmitz
Copy link
Contributor

@ianschmitz ianschmitz commented Jan 5, 2019 •
edited
Loading

Closes #6115.

We are able to use detect instead of the obscure 999.999.999 value for the react version of the eslint-loader config after bumping eslint-plugin-react.

@ianschmitz ianschmitz added this to the 2.1.4 milestone Jan 5, 2019
@ianschmitz ianschmitz requested a review from Timer January 5, 2019 07:42
@ghost
Copy link

ghost commented Jan 5, 2019 •
edited by ghost
Loading

Should not you change all related places?
https://github.com/facebook/create-react-app/pull/5043/files

@ianschmitz
Copy link
Contributor Author

The webpack dev and prod files were merged into one file a while back.

Timer
Timer approved these changes Jan 5, 2019
View reviewed changes
Copy link
Contributor

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertvansteen
Copy link
Contributor

What's the reason that the build fails here? I'm having the same problem on my PR.

@ianschmitz
Copy link
Contributor Author

@rovansteen looks related to #6099.

@ianschmitz
Copy link
Contributor Author

@Timer Travis is reporting the same warning that you experienced in #5043, however I don't see that locally when running yarn build. I tried clearing the master/my PR caches in Travis, but got the same result :(

@Timer Timer closed this Jan 6, 2019
@Timer Timer reopened this Jan 6, 2019
@ianschmitz ianschmitz closed this Jan 6, 2019
@ianschmitz ianschmitz reopened this Jan 6, 2019
@Timer
Copy link
Contributor

Timer commented Jan 6, 2019

Let's turn on react/no-typos as an error. It seems really helpful!

@ianschmitz
Copy link
Contributor Author

@Timer done!

@ianschmitz ianschmitz merged commit 005ee5b into facebook:master Jan 6, 2019
@ianschmitz ianschmitz deleted the eslint-react-version branch January 7, 2019 00:45
@ianschmitz ianschmitz mentioned this pull request Jan 7, 2019
Closed
mrmckeb pushed a commit to BeameryHQ/bmr-react-scripts that referenced this pull request Jan 10, 2019
@ianschmitz
Bump eslint-plugin-react version and update webpack config (facebook#…
dabd0a7 
…6132)

* Bump eslint-plugin-react version

* Move eslint-plugin-react settings into eslint-config-react-app

* Add react/no-typos rule
@sidharthachatterjee sidharthachatterjee mentioned this pull request Jan 10, 2019
Closed
@lock lock bot locked and limited conversation to collaborators Jan 12, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@Timer Timer Timer approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: underlying tools
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ianschmitz @robertvansteen @Timer @facebook-github-bot