Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

change default import into named import #6623

Closed
wants to merge 1 commit into from
Closed

change default import into named import #6623

wants to merge 1 commit into from

Conversation

xiaoxiangmoe
Copy link
Contributor

Consistent with the code below:

@xiaoxiangmoe xiaoxiangmoe marked this pull request as ready for review March 12, 2019 06:36
@xiaoxiangmoe xiaoxiangmoe changed the title change default export into named export change default import into named import Mar 12, 2019
@Timer
Copy link
Contributor

Timer commented Mar 12, 2019

import * as React from 'react'; seems to be an accident, all this code should read import React from 'react';.

Thanks for the PR, can you update the other file?

@xiaoxiangmoe
Copy link
Contributor Author

xiaoxiangmoe commented Mar 12, 2019

@Timer In TypeScript Doc it write:

import * as React from "react";

Should we use named export rather than default export?

Named export seems to be a more accurate way of expressing the export of react.

I'll open another pull request to change named import into default import.

@ianschmitz ianschmitz closed this Mar 12, 2019
@lock lock bot locked and limited conversation to collaborators Mar 17, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants