Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to core-js@3 #6769

Merged
merged 4 commits into from
Apr 14, 2019
Merged

Update to core-js@3 #6769

merged 4 commits into from
Apr 14, 2019

Conversation

ianschmitz
Copy link
Contributor

@ianschmitz ianschmitz commented Apr 7, 2019

This is a breaking change to our 3.0 alpha that deprecates the @babel/polyfill feature in favor of the recommended approach from the babel team as part of the babel 7.4.0 release. This adds a new react-app-polyfill/stable module that can be imported from src/index.js which will include polyfills for stable language features, and integrates nicely with @babel/preset-env which uses browserslist to only include polyfills for the target browsers.

Some more relevant info on this change: https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md#babel

Outstanding questions:

  • In the corejs@2 migration guide it says
    • If you are using @babel/plugin-transform-runtime, you need to use the corejs: 3 option

    • We currently have corejs: false so my sense is we can ignore this, but it would be helpful if someone with more knowledge of this plugin could chime in

Co-Authored-By: ianschmitz <ianschmitz@gmail.com>
@ianschmitz ianschmitz merged commit bffc296 into facebook:master Apr 14, 2019
@ianschmitz ianschmitz deleted the corejs-update branch April 14, 2019 23:53
@brunolemos
Copy link
Contributor

There is no react-app-polyfill/stable in the published version.

"react-app-polyfill": "1.0.0-next.b0cbf2ca",
"react-scripts": "3.0.0-next.b0cbf2ca",

@ianschmitz
Copy link
Contributor Author

This was just merged in recently @brunolemos. We will publish a new alpha shortly.

@iansu iansu mentioned this pull request Apr 17, 2019
@lock lock bot locked and limited conversation to collaborators Apr 20, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants