Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add clarifying note to TypeScript docs warning about global install of CRA #6945

Merged
merged 2 commits into from
May 1, 2019
Merged

Add clarifying note to TypeScript docs warning about global install of CRA #6945

merged 2 commits into from
May 1, 2019

Conversation

methodbox
Copy link
Contributor

Added block quote with warning about issues when CRA is installed globally.

Related to: #6816 & #6911

Updating blockquote to advise on use of CRA globally vs. npx when using --typescript flag.

Added block quote with warning about issues when CRA is installed globally.
@amyrlam amyrlam added this to the 3.0.1 milestone Apr 28, 2019
@amyrlam amyrlam changed the title amend-docs-adding-typescript Add clarifying note to TypeScript docs warning about global install of CRA Apr 28, 2019
Co-Authored-By: methodbox <chris@methodbox.io>
Copy link
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing your fork and resubmitting! 🎉 Looks good to me, will let @iansu confirm.

@amyrlam amyrlam merged commit 6710f52 into facebook:master May 1, 2019
@amyrlam
Copy link
Contributor

amyrlam commented May 1, 2019

I reworded the title too long with the PR number amended to end (#6945), will account for that in commit length next time.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants