Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ESLint 6 support #7415

Merged
merged 2 commits into from
Jul 28, 2019
Merged

Add ESLint 6 support #7415

merged 2 commits into from
Jul 28, 2019

Conversation

mrmckeb
Copy link
Contributor

@mrmckeb mrmckeb commented Jul 23, 2019

Closes #7268.

@mrmckeb mrmckeb force-pushed the feature/eslint-6 branch 5 times, most recently from 604ef2c to a78d4aa Compare July 24, 2019 05:13
@mrmckeb
Copy link
Contributor Author

mrmckeb commented Jul 24, 2019

Hi @not-an-aardvark,

I saw that you've worked a lot on the ESLint 6 resolution changes. Our config has broken as we've upgraded to ESLint 6 and I'm not sure how to resolve it - any help would be greatly appreciated!

@not-an-aardvark
Copy link

It looks like the issue is that eslint-plugin-import fails to be loaded. I think the solution would be to use the --resolve-plugins-relative-to flag (which is intended for projects like create-react-app that install plugins and run ESLint on behalf of the end user).

I think adding a property like resolvePluginsRelativeTo: __dirname here should fix the issue.

@mrmckeb
Copy link
Contributor Author

mrmckeb commented Jul 25, 2019

Thanks @not-an-aardvark, that was spot-on. Does this change mean that we could make the plugins dependencies of the shared config now, as opposed to peer dependencies?

Again, thanks for your help on this!

@not-an-aardvark
Copy link

No, they still have to be peer dependencies at this point. If you're interested, eslint/rfcs#14 contains some additional info/discussion on the possibility of allowing them to be dependencies in the future.

@mrmckeb
Copy link
Contributor Author

mrmckeb commented Jul 28, 2019

Thanks @not-an-aardvark - will check that out and follow it!

And thanks for the approval @ianschmitz.

@mrmckeb mrmckeb merged commit 404af90 into master Jul 28, 2019
@mrmckeb mrmckeb deleted the feature/eslint-6 branch July 28, 2019 12:05
Copy link
Contributor

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs need updated to reflect new versions.

@mrmckeb
Copy link
Contributor Author

mrmckeb commented Jul 30, 2019

Good pick-up @Timer! Will do in the next few hours.

@nickserv
Copy link
Contributor

Thanks for supporting this. Is there a timeline for the next eslint-config-react-app release?

@mrmckeb
Copy link
Contributor Author

mrmckeb commented Jul 31, 2019

Yes, 100%. We had planned it for this week, but I think it's likely to be next week.

Very close now :)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESLint v6 was released.
7 participants