-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add ESLint 6 support #7415
Add ESLint 6 support #7415
Conversation
ac53615
to
70d2533
Compare
604ef2c
to
a78d4aa
Compare
Hi @not-an-aardvark, I saw that you've worked a lot on the ESLint 6 resolution changes. Our config has broken as we've upgraded to ESLint 6 and I'm not sure how to resolve it - any help would be greatly appreciated! |
It looks like the issue is that I think adding a property like |
Thanks @not-an-aardvark, that was spot-on. Does this change mean that we could make the plugins dependencies of the shared config now, as opposed to peer dependencies? Again, thanks for your help on this! |
No, they still have to be peer dependencies at this point. If you're interested, eslint/rfcs#14 contains some additional info/discussion on the possibility of allowing them to be dependencies in the future. |
Thanks @not-an-aardvark - will check that out and follow it! And thanks for the approval @ianschmitz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs need updated to reflect new versions.
Good pick-up @Timer! Will do in the next few hours. |
Thanks for supporting this. Is there a timeline for the next |
Yes, 100%. We had planned it for this week, but I think it's likely to be next week. Very close now :) |
Closes #7268.