Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add explicit check for --watchAll=false #7433

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Conversation

mrmckeb
Copy link
Contributor

@mrmckeb mrmckeb commented Jul 26, 2019

Resolves #7180.

All tests are currently exiting with a 0 code, regardless of failures. This causes issues in CI environment and Git hooks.

Copy link

@bugzpodder bugzpodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Tested it and it worked out.

@iansu iansu merged commit cbad256 into master Jul 26, 2019
@iansu iansu deleted the feature/fix-test-exit-codes branch July 26, 2019 18:27
ghengeveld added a commit to async-library/react-async that referenced this pull request Jul 26, 2019
@lock lock bot locked and limited conversation to collaborators Jul 31, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-scripts test (or Jest) is reporting exit code 0 on test failures
5 participants