set output.globalObject to 'this' #7742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
I had made this change in an older WebWorker PR but we never did merge it. We're still working on adding built in support for WebWorkers but this seems like a good way to let people use them in the meantime. |
|
I'm not sure why all of our Windows tests are failing but it's not related to this change. |
|
Thanks! |
|
Thank you! Where can I learn about when this will get released? |
|
We don't really have a firm date for 3.1.3 but I would guess sometime next week. There are a couple other PRs that would be good to get in before we shift over to working on 3.2. |
|
If you want to know when the release happens follow me on Twitter. I always announce releases there. 😀 |
hchiam
added a commit
to hchiam/create-react-app
that referenced
this pull request
Sep 27, 2019
set output.globalObject to 'this' (facebook#7742)
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7741
Verified that this works locally. See #7741 for screenshots/context.