Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add yarn.lock to .gitignore #7789

Merged
merged 1 commit into from
Oct 27, 2019
Merged

Add yarn.lock to .gitignore #7789

merged 1 commit into from
Oct 27, 2019

Conversation

lukyth
Copy link
Contributor

@lukyth lukyth commented Oct 6, 2019 •
edited
Loading

Close #7765

Description

From #7765, yarn.lock hasn't been dealt with yet in this project.

According to the discussion in that issue, yarn.lock should be ignored in this project.

Acceptance criteria

  • git status should be unchanged when running yarn for the first time.
  • yarn.lock should be ignored in .gitignore.

@ianschmitz ianschmitz added this to the 3.2.1 milestone Oct 14, 2019
@iansu iansu modified the milestones: 3.2.1, 3.3 Oct 23, 2019
@ianschmitz ianschmitz merged commit c34aa13 into facebook:master Oct 27, 2019
@ianschmitz
Copy link
Contributor

Thanks!

@lukyth lukyth deleted the lukyth/ignore-yarn-lock branch October 28, 2019 10:33
@lock lock bot locked and limited conversation to collaborators Nov 2, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ianschmitz ianschmitz ianschmitz approved these changes

@fanny fanny fanny approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

yarn.lock is untracked when setting up a local copy of the project
5 participants
@lukyth @ianschmitz @fanny @iansu @facebook-github-bot