Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix cli bin path #8

Merged
merged 1 commit into from
Jul 17, 2016
Merged

Fix cli bin path #8

merged 1 commit into from
Jul 17, 2016

Conversation

keyz
Copy link
Contributor

@keyz keyz commented Jul 17, 2016

The current setup doesn't work with nvm: the create-react-app file doesn't get added to npm's global .bin folder. Adding a ./ prefix fixed this.

https://docs.npmjs.com/files/package.json#bin

@ghost ghost added the CLA Signed label Jul 17, 2016
@vjeux vjeux merged commit b1cf65e into facebook:master Jul 17, 2016
@keyz
Copy link
Contributor Author

keyz commented Jul 17, 2016

@vjeux could/did you publish a new version? :)

@vjeux
Copy link
Contributor

vjeux commented Jul 17, 2016

This is not on npm yet. What new version do you want me to release?

@keyz
Copy link
Contributor Author

keyz commented Jul 17, 2016

@gaearon
Copy link
Contributor

gaearon commented Jul 17, 2016

That's a placeholder package for now. It just has a name but no code. We'll keep it that way until the official release. For now "Contributing" flow in README is the only way to test this thing!

@gaearon
Copy link
Contributor

gaearon commented Jul 17, 2016

(I guess npm link could also work)

@keyz
Copy link
Contributor Author

keyz commented Jul 17, 2016

@gaearon lol so that's why i got no bin after running npm install -g create-react-app! Should have asked you before haha. but this PR should be fine anyway (I published my own fork on npm and tested it). :)

@gaearon
Copy link
Contributor

gaearon commented Jul 17, 2016

Please be careful publishing forks, somebody might watch your account and then it'll be all over Twitter ;-)

@keyz
Copy link
Contributor Author

keyz commented Jul 17, 2016

Yeah I unpublished it already after testing :)

vjeux pushed a commit that referenced this pull request Jul 18, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants