Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update docusaurus & tweak site #8111

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Dec 7, 2019

Motivation

Bump docusaurus 2 to latest version. There are lot of improvements such as smaller client bundle size, better a11y, better dark-mode, line highlighting, etc and so on. Can check full changelog here https://github.com/facebook/docusaurus/blob/master/CHANGELOG-2.x.md

I also tweaked the CSS abit.

One thing I notice too is that Algolia docsearch has never been updated from algolia side, so its appending weird #docsNav (legacy of v1). I sent a PR to docsearch for update

Don't merge yet until algolia/docsearch-configs#1165 land.

https://deploy-preview-8111--create-react-app.netlify.com/

Test Plan

2  after cra dark mode

2  after cra

3  dark mode better color

@iansu iansu added this to the 3.3.1 milestone Dec 10, 2019
@iansu iansu merged commit 1f1594d into facebook:master Dec 10, 2019
@iansu
Copy link
Contributor

iansu commented Dec 10, 2019

Thank you!

@lock lock bot locked and limited conversation to collaborators Dec 15, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants