Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use native ESLint behaviour when extending #8276

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Conversation

mrmckeb
Copy link
Contributor

@mrmckeb mrmckeb commented Jan 3, 2020

Resolves #7776.

This PR updates the docs to meet the current implementation, and falls back to native ESLint extends behaviour when the user sets EXTEND_ESLINT.

@mrmckeb mrmckeb requested a review from ianschmitz January 3, 2020 08:58
@mrmckeb mrmckeb self-assigned this Jan 3, 2020
@mrmckeb mrmckeb added this to the 3.4 milestone Jan 3, 2020
@mrmckeb mrmckeb modified the milestones: 3.4, 3.3.1 Jan 8, 2020
@ianschmitz ianschmitz modified the milestones: 3.3.1, 3.4 Jan 31, 2020
@iansu iansu modified the milestones: 3.4, 3.5 Feb 14, 2020
@ianschmitz ianschmitz modified the milestones: 3.5, 3.4.1 Feb 19, 2020
@ianschmitz ianschmitz closed this Feb 19, 2020
@ianschmitz ianschmitz reopened this Feb 19, 2020
@hatched-tom
Copy link

Just been looking through the PR - wondering if there is any reason why it's still waiting to be merged? (not familiar with the process 😅 )

@mrmckeb
Copy link
Contributor Author

mrmckeb commented Mar 1, 2020

Good question, I think this was missed. @ianschmitz shall we merge this in and get it out with the next release?

@ianschmitz ianschmitz merged commit 4d26208 into master Mar 1, 2020
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
@ianschmitz ianschmitz deleted the feature/eslint-fixes branch March 20, 2020 23:48
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending ESLint is not supporting overrides
6 participants