Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove outdated babel plugins #8353

Merged
merged 10 commits into from
Jan 30, 2020
Merged

Conversation

ianschmitz
Copy link
Contributor

@ianschmitz ianschmitz commented Jan 21, 2020

Removes plugins unnecessary after the 7.8.0 release of babel: https://babeljs.io/blog/2020/01/11/7.8.0.

@babel/plugin-transform-destructuring is handled by preset-env, but i left it in due to our hooks optimizations: https://github.com/ianschmitz/create-react-app/blob/fc69d915430408c6ecec51d91a1a62fcb494df90/packages/babel-preset-react-app/create.js#L124

Also updates some other dependencies missed in #8324.

@existentialism
Copy link
Contributor

existentialism commented Jan 21, 2020

FWIW, I think we're going to drop a patch release (7.8.4) today or tomorrow.

EDIT: Sorry for the delay, it's going out tomorrow! 🙃

@mrmckeb
Copy link
Contributor

mrmckeb commented Jan 22, 2020

Looks good, let's wait for the patch and go for it @ianschmitz.

@henryqdineen
Copy link
Contributor

Regarding @babel/plugin-transform-destructuring: I don’t think the “hooks optimization” actually does anything currently. See: #8215

@ianschmitz ianschmitz merged commit b855da5 into facebook:master Jan 30, 2020
@ianschmitz ianschmitz deleted the update-babel branch January 30, 2020 22:18
@lock lock bot locked and limited conversation to collaborators Feb 4, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants