Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump React Hooks ESLint plugin to 4.0.0 #8939

Merged
merged 3 commits into from
May 4, 2020
Merged

Bump React Hooks ESLint plugin to 4.0.0 #8939

merged 3 commits into from
May 4, 2020

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented May 1, 2020

Changelog: https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md

Note some of these will likely cause false positives:

People who get them will likely complain because it's really annoying. But we think the change itself is worth it and it's a bitter pill we need to swallow now rather than prolong it. The workaround, as always, is to disable-line the ones that are false positives and, ideally, rename them in code.

@ianschmitz ianschmitz merged commit fa93437 into master May 4, 2020
@ianschmitz ianschmitz deleted the lint branch May 4, 2020 01:27
@ianschmitz
Copy link
Contributor

Thanks Dan!

@iansu, this would be good to reference in the release notes when we get to it to set expectations of the false positives.

@lock lock bot locked and limited conversation to collaborators May 20, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants