Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix dotenv file loading order #9037

Merged
merged 4 commits into from
May 29, 2020
Merged

Fix dotenv file loading order #9037

merged 4 commits into from
May 29, 2020

Conversation

Timer
Copy link
Contributor

@Timer Timer commented May 20, 2020

This fixes the loading priority order to match that of the dotenv spec:
https://github.com/bkeepers/dotenv#what-other-env-files-can-i-use

@Timer Timer added this to the 4.0 milestone May 20, 2020
@ianschmitz
Copy link
Contributor

Thanks Joe. Looks like a test needs to be updated.

@mrmckeb mrmckeb merged commit 26a1c7f into facebook:master May 29, 2020
@Timer Timer deleted the hotfix/dotenv-order branch May 29, 2020 15:16
@Timer
Copy link
Contributor Author

Timer commented May 29, 2020

Thanks @mrmckeb for handling the test updates!

rfreling pushed a commit to rfreling/create-react-app that referenced this pull request May 30, 2020
@Timer @mrmckeb @rfreling
Fix dotenv file loading order (facebook#9037)
7b506db 
* Fix dotenv file loading order

* tests: fix failing env tests

* tests: fix more failing tests

Co-authored-by: Brody McKee <mrmckeb@hotmail.com>
@mrmckeb
Copy link
Contributor

mrmckeb commented May 31, 2020 •
edited
Loading

No problem, I know you're super busy.

victor-travelperk pushed a commit to travelperk/create-react-app that referenced this pull request Jun 8, 2020
@Timer @mrmckeb @victor-travelperk
Fix dotenv file loading order (facebook#9037)
f14090e 
* Fix dotenv file loading order

* tests: fix failing env tests

* tests: fix more failing tests

Co-authored-by: Brody McKee <mrmckeb@hotmail.com>
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@iansu iansu iansu approved these changes

@rodoabad rodoabad rodoabad approved these changes

@petetnt petetnt petetnt approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

Assignees
No one assigned
Labels
CLA Signed tag: breaking change tag: bug fix
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Timer @ianschmitz @mrmckeb @iansu @rodoabad @petetnt @facebook-github-bot