Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(v2): add arabic translation #4329

Merged
merged 1 commit into from
Mar 3, 2021
Merged

feat(v2): add arabic translation #4329

merged 1 commit into from
Mar 3, 2021

Conversation

3alisaki
Copy link
Contributor

@3alisaki 3alisaki commented Mar 2, 2021

Motivation

New Translation for Arabic.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run yarn run start:v2 and check that the page http://localhost:3000/ is rendered properly.

Related PRs

None

@3alisaki 3alisaki requested review from lex111 and slorber as code owners March 2, 2021 23:11
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 2, 2021
@netlify
Copy link

netlify bot commented Mar 2, 2021

[V1] Deploy preview failure

Built without sensitive environment variables with commit a39cdda

https://app.netlify.com/sites/docusaurus-1/deploys/603ec6193da1770007b13279

@netlify
Copy link

netlify bot commented Mar 2, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit a39cdda

https://deploy-preview-4329--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4329--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

Size Change: 0 B

Total Size: 532 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.1 kB 0 B
website/build/assets/js/main.********.js 359 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.4 kB 0 B

compressed-size-action

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Mar 3, 2021
@slorber slorber changed the title add arabic translation feat(v2): add arabic translation Mar 3, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 3, 2021

thanks 👍

@slorber slorber merged commit 4162e6d into facebook:master Mar 3, 2021
@3alisaki 3alisaki deleted the arabic-translation branch March 3, 2021 11:15
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 4, 2021
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
This was referenced Mar 13, 2021
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
@NikolayS NikolayS mentioned this pull request Feb 11, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

@slorber slorber Awaiting requested review from slorber

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Milestone
v2.0.0-alpha.71
Development

Successfully merging this pull request may close these issues.
4 participants
@3alisaki @slorber @lex111 @facebook-github-bot