Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(showcase): add 74 new showcase sites #8010

Merged
merged 7 commits into from
Aug 31, 2022
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 26, 2022

Motivation

Add all new showcase submissions above comment #7826 (comment)


FYI we are moving site screenshots to a serverless screenshot service.

https://slorber-api-screenshot.netlify.app/<siteUrl>/showcase

For example: https://slorber-api-screenshot.netlify.app/https%3A%2F%2Fdocusaurus.io%2F/showcase
Will render:

We know about some limitations of the screenshot service:

  • render unwanted announcement bars, cookie banners
  • render spinners, does not wait for some elements to load
  • fails to render emojis
  • respect or not dark mode
  • ...

We are going to ship it as is for now, and improve it over time so that all sites in our showcase render nicely

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 26, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 26, 2022
@netlify
Copy link

netlify bot commented Aug 26, 2022

[V2]

Name Link
🔨 Latest commit ab30d3c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/630f518491bbb2000add52c5
😎 Deploy Preview https://deploy-preview-8010--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Aug 26, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 79 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 78 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented Aug 26, 2022

Size Change: +100 B (0%)

Total Size: 814 kB

Filename Size Change
website/build/assets/js/main.********.js 610 kB +100 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.5 kB
website/build/assets/css/styles.********.css 111 kB
website/build/index.html 40.9 kB

compressed-size-action

@slorber
Copy link
Collaborator Author

slorber commented Aug 26, 2022

All Docusaurus sites submitted have been added in the PR, or rejected with a comment

Ping all submitters:
@vladfrangu @Zamiell @nvh95 @TheCatLady @pkosiec @manuel-rw @jaapstronks @kgajera @Licenser @jspinak @RichKurtzman @yangshun @ViktorWiz @xiaohai-huang @tseijp @thecodinghabits @B4nan @canuto @xiaohuilam @Ouch1978 @RomanKondratyev @ziarparvaiz @ccamel @ariafloat @ainhoa-a @github0null @gustavosbarreto @fishcharlie @anaclumos @jy95 @redonkulus @andrewnicols @kanekotic @nikitavoloboev @LewisRichardson @apisit @hamza1311 @suntudo @dvitanov @jhbeard @DevTomek-pl @vantevo-analytics @danchanka @sgtrueloverokt @alexmercerind @palante @ivishalgandhi @FrancescoXX @yoannfleurydev @wenerme @wafflecoffee @juli1 @webbertakken @charleskorn @WasiqB @rguldener @marcos-muino-garcia @seyfeddin @harinij @nooges @tpascarella @lzwdot @dpimonov @iosifache @gneyal @shoaibsajid1 @arobbins @DrW3RK

@slorber
Copy link
Collaborator Author

slorber commented Aug 26, 2022

Ping2 @wafflecoffee @juli1 @webbertakken @charleskorn @WasiqB @rguldener @marcos-muino-garcia @seyfeddin @harinij @nooges @tpascarella @lzwdot @dpimonov @iosifache @gneyal @shoaibsajid1 @arobbins @DrW3RK

@andrewnicols
Copy link
Contributor

Perhaps I'm being dense, but how can you tell the state of the filters at the top of the showcase?

I can't tell which of the following (if any) are enabled:

Screen Shot 2022-08-27 at 00 02 47

@Josh-Cena
Copy link
Collaborator

The green ones are selected. Maybe there isn't enough contrast difference for color-blind folks—I would fix that by adding an icon soon.

@andrewnicols
Copy link
Contributor

The green ones are selected. Maybe there isn't enough contrast difference for color-blind folks—I would fix that by adding an icon soon.

As a colour-blind person, I can confirm. It's only a problem in dark-mode. I expected the buttons to change somehow - perhaps to go from an outlined circle to a filled circle (though that has other issues). Perhaps inverting the colour?

@Josh-Cena
Copy link
Collaborator

Right. Here's what I made for the TS-ESLint website: https://typescript-eslint.io/rules/

@andrewnicols
Copy link
Contributor

Right. Here's what I made for the TS-ESLint website: https://typescript-eslint.io/rules/

That works well. I can see that ;). Thanks.

@slorber
Copy link
Collaborator Author

slorber commented Aug 31, 2022

Perhaps I'm being dense, but how can you tell the state of the filters at the top of the showcase?

@andrewnicols this is not really a good place to discuss showcase page accessibility issues

I'll keep this in mind, but it would be better to open a dedicated issue, and suggest a proposal that works for you

@slorber slorber merged commit 97c9710 into main Aug 31, 2022
@slorber slorber deleted the slorber/update-showcase-august branch August 31, 2022 12:28
This was referenced Oct 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants