Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: improve alt messages #8047

Merged
merged 1 commit into from
Sep 4, 2022
Merged

docs: improve alt messages #8047

merged 1 commit into from
Sep 4, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I was working on MDN's image alts, and I was greatly inspired. The idea is that it should fully describe what the image is about to someone who can't see the image — imagine you don't have internet. See mdn/mdn-community#168

Also, decorative images should not have alt texts at all.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 4, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 4, 2022
@netlify
Copy link

netlify bot commented Sep 4, 2022

[V2]

Name Link
🔨 Latest commit 3990ab0
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/631436aee3e0e300088c41a4
😎 Deploy Preview https://deploy-preview-8047--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 54 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 72 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena merged commit 36db64e into main Sep 4, 2022
@Josh-Cena Josh-Cena deleted the better-alt branch September 4, 2022 05:33
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Size Change: 0 B

Total Size: 813 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.1 kB
website/build/assets/css/styles.********.css 111 kB
website/build/assets/js/main.********.js 609 kB
website/build/index.html 40.8 kB

compressed-size-action

slorber pushed a commit that referenced this pull request Sep 7, 2022
This was referenced Oct 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants