Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(mdx-loader): upgrade to MDX v3 #9451

Merged
merged 24 commits into from
Oct 26, 2023
Merged

feat(mdx-loader): upgrade to MDX v3 #9451

merged 24 commits into from
Oct 26, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 25, 2023 •
edited
Loading

Breaking change

Motivation

MDX v3 is out, but Docusaurus v3 is around the corner.

It's a small release so let's see if we can include it or if we'll keep it for Docusaurus v4.

Test Plan

CI

Test links

https://deploy-preview-9451--docusaurus-2.netlify.app/

@slorber slorber added pr: new feature This PR adds a new API or behavior. pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. labels Oct 25, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 25, 2023
@slorber slorber added this to the 3.0 milestone Oct 25, 2023
@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ [V2]

Name Link
🔨 Latest commit 0ab4fee
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/653a69ffce6e0600082707d3
😎 Deploy Preview https://deploy-preview-9451--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 69 🟢 97 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 53 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 62 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 62 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 65 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 63 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 65 🟢 100 🟢 100 🟢 90 🟠 89 Report

@argos-ci
Copy link

argos-ci bot commented Oct 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 8 changes Oct 26, 2023, 1:42 PM

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 117 kB
website/build/assets/css/styles.********.css 113 kB
website/build/assets/js/main.********.js 862 kB
website/build/index.html 41.4 kB

compressed-size-action

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 26, 2023
View reviewed changes
jest/vendor/remark-rehype@11.0.0.js
if (code2 === 37 && asciiAlphanumeric(value.charCodeAt(index + 1)) && asciiAlphanumeric(value.charCodeAt(index + 2))) {
skip = 2;
} else if (code2 < 128) {
if (!/[!#$&-;=?-Z_a-z~]/.test(String.fromCharCode(code2))) {

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[&'()*+,\-.\/0-9:;\].
jest/vendor/remark-rehype@11.0.0.js
if (code2 === 37 && asciiAlphanumeric(value.charCodeAt(index + 1)) && asciiAlphanumeric(value.charCodeAt(index + 2))) {
skip = 2;
} else if (code2 < 128) {
if (!/[!#$&-;=?-Z_a-z~]/.test(String.fromCharCode(code2))) {

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[?@A-Z\].
@slorber slorber changed the title feat: upgrade to MDX v3 feat(mdx-loader): upgrade to MDX v3 Oct 26, 2023
@slorber slorber merged commit 7e456ec into main Oct 26, 2023
@slorber slorber deleted the slorber/mdx-v3 branch October 26, 2023 13:47
@slorber slorber mentioned this pull request Oct 26, 2023
Merged
@tats-u tats-u mentioned this pull request Oct 30, 2023
Merged
3 tasks
@NikolayS NikolayS mentioned this pull request Nov 28, 2023
Open
@Abuchtela Abuchtela mentioned this pull request May 20, 2024
Closed
This was referenced May 26, 2024
Closed
Closed
Closed
This was referenced Jun 14, 2024
Closed
Closed
This was referenced Jun 15, 2024
Closed
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
This was referenced Jun 20, 2024
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: new feature This PR adds a new API or behavior.
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@slorber @facebook-github-bot