fix(babel-plugin-fbt): detect fbt JS callsites from FbtCollector

facebook · Sep 2, 2021 · 761a1d5 · 761a1d5
1 parent 8ac3e66
commit 761a1d5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/packages/babel-plugin-fbt/src/bin/FbtCollector.js b/packages/babel-plugin-fbt/src/bin/FbtCollector.js
@@ -14,6 +14,7 @@
 const {extractEnumsAndFlattenPhrases} = require('../FbtShiftEnums');
 // eslint-disable-next-line fb-www/no-module-aliasing
 const fbt = require('../index');
+const FbtUtil = require('../FbtUtil');
 const fs = require('graceful-fs');
 const path = require('path');
 
@@ -101,7 +102,7 @@ class FbtCollector implements IFbtCollector {
       options.filename = filename;
     }
 
-    if (!/<[Ff]bt|fbt(\.c)?\s*\(/.test(source)) {
+    if (!FbtUtil.textContainsFbtLikeModule(source)) {
       return;
     }
 

diff --git a/packages/babel-plugin-fbt/src/bin/__tests__/collectFBT-test.js b/packages/babel-plugin-fbt/src/bin/__tests__/collectFBT-test.js
@@ -60,7 +60,7 @@ describe('collectFbt', () => {
     }
   }
 
-  it('should extract strings', () => {
+  it('should extract fbt strings', () => {
     var res = collect('const fbt = require(\'fbt\');<fbt desc="foo">bar</fbt>');
 
     var expected = {
@@ -75,6 +75,21 @@ describe('collectFbt', () => {
     expect(actual).toEqual(expected);
   });
 
+  it('should extract fbs strings', () => {
+    var res = collect('const fbs = require(\'fbs\');<fbs desc="foo">bar</fbs>');
+
+    var expected = {
+      type: 'text',
+      desc: 'foo',
+      jsfbt: 'bar',
+    };
+
+    var actual = {};
+    Object.keys(expected).map(key => (actual[key] = res.phrases[0][key]));
+
+    expect(actual).toEqual(expected);
+  });
+
   it('should still extract strings if file-level doNotExtract is set to false', () => {
     var res = collect(
       [