Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Commit

Permalink
Remove file logger
Browse files Browse the repository at this point in the history
Summary: Not necessary, and unused.

Reviewed By: passy

Differential Revision: D56528659

fbshipit-source-id: 0a2d6bb82aa0b9bc3ddf8fcfe4bc4acd9cd139dc
  • Loading branch information
lblasa authored and facebook-github-bot committed Apr 25, 2024
1 parent 7b77a9a commit 12737bc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 60 deletions.
62 changes: 3 additions & 59 deletions desktop/flipper-server/src/logger.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,72 +7,16 @@
* @format
*/

import path from 'path';
import {
addLogTailer,
EnvironmentInfo,
LoggerExtractError,
LoggerFormat,
LoggerTypes,
setLoggerInstance,
} from 'flipper-common';
// @ts-expect-error
import fsRotator from 'file-stream-rotator';
import {ensureFile} from 'fs-extra';
import {access} from 'fs/promises';
import {constants} from 'fs';
import {EnvironmentInfo, setLoggerInstance} from 'flipper-common';

import {initializeLogger as initializeLoggerCore} from './fb-stubs/Logger';
import {setProcessExitRoutine} from './utils/processExit';

export const loggerOutputFile = 'flipper-server-log.out';

export async function initializeLogger(
environmentInfo: EnvironmentInfo,
staticDir: string,
) {
export async function initializeLogger(environmentInfo: EnvironmentInfo) {
// Suppress stdout debug messages, but keep writing them to the file.
console.debug = function () {};

const logger = initializeLoggerCore(environmentInfo);
setLoggerInstance(logger);

const logFilename = path.join(staticDir, loggerOutputFile);
let logStream: NodeJS.WriteStream | undefined = undefined;
try {
await ensureFile(logFilename);
await access(logFilename, constants.W_OK);
logStream = fsRotator.getStream({
// Rotation number is going to be added after the file name
filename: logFilename,
// Rotate every 1MB
size: '1m',
// Keep last 5 rotations
max_logs: 20,
});
} catch (e) {
console.warn('initializeLogger -> cannot write logs to FS', e);
}

addLogTailer((level: LoggerTypes, ...data: Array<any>) => {
const logInfo = LoggerFormat(level, ...data);
logStream?.write(`[${logInfo.time}][${logInfo.type}] ${logInfo.msg}\n`);

if (level === 'error') {
const {
error: {stack, name},
} = LoggerExtractError(data);

logStream?.write(`${name}: \n${stack}\n`);
}
});

const finalizeLogger = async () => {
const logStreamToEnd = logStream;
// Prevent future writes
logStream = undefined;
await new Promise<void>((resolve) => {
logStreamToEnd?.end(resolve);
});
};
setProcessExitRoutine(finalizeLogger);
}
2 changes: 1 addition & 1 deletion desktop/flipper-server/src/startServer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ async function start() {
process.env.NODE_ENV !== 'development' && process.env.NODE_ENV !== 'test';
const environmentInfo = await getEnvironmentInfo(rootPath, isProduction);

await initializeLogger(environmentInfo, staticPath);
await initializeLogger(environmentInfo);

const t1 = performance.now();
const loggerInitializedMS = t1 - t0;
Expand Down

0 comments on commit 12737bc

Please # to comment.