-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix comment syntax inside jsx #7674
Conversation
What's the use case for this? Has this been requested? |
@gabelevi isn't it more consistent for comment syntax to work everywhere? |
@gabelevi I updated main post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me!
A lot of the code looks copy/pasted. Can you move it into a helper function?
I can't test it now, but I'm not sure if this would be allowed too? </*::Test*/ /> If it is, I would like to disallow it probably |
@gabelevi I'm going to close it because I'm not really want to introduce some unexpected behaviour here with jsx, also I think this is not worth it |
Temporary workaround for #7672