Skip to content

Commit

Permalink
Don't use private googletest API in TestUtils.h
Browse files Browse the repository at this point in the history
Summary:
Until [very recently](google/googletest#2517), `googletest` did not print the skip message in any shape or form, so nothing can possibly depend on us customizing the skip message here.

The default is perfectly fine, let's keep it simple.

Reviewed By: yfeldblum

Differential Revision: D18051635

fbshipit-source-id: f7b889b0adf5e34a70c2579a34748bb159809b3c
  • Loading branch information
snarkmaster authored and facebook-github-bot committed Oct 23, 2019
1 parent 509999e commit d32d434
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion folly/test/TestUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
// that can identify the "Test skipped by client" in the failure message
// and convert this into a skipped test result.
#ifdef GTEST_SKIP_
#define SKIP(msg) GTEST_SKIP_("Test skipped by client")
#define SKIP(msg) GTEST_SKIP()
#else
#define SKIP() \
GTEST_AMBIGUOUS_ELSE_BLOCKER_ \
Expand Down

0 comments on commit d32d434

Please # to comment.