[apple][v0.7] Define the deployment target in the frameworks metadata #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@Huxpro Unsure about those e2e test failures, but this should otherwise be good to go 👍 |
This was referenced Dec 4, 2020
alloy
deleted the
add-deployment-target-metadata-to-apple-artefacts-v0.7
branch
Huxpro
changed the title
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 8, 2021
Summary: Fixes #420 Apple App Store submission, at least the iOS one, requires this metadata to be specified when only targeting a subset of possible archs. Pull Request resolved: #425 Test Plan: (Taken from #428) ``` ~/tmp » curl -L -O https://12725-154201259-gh.circle-artifacts.com/0/tmp/hermes/output/hermes-engine-darwin-v0.7.1.tgz ~/tmp » tar -zvxf hermes-engine-darwin-v0.7.1.tgz ~/tmp » cd package/ ~/t/package » node unpack-tarball.js ~/t/package » /usr/libexec/PlistBuddy -c 'Print :MinimumOSVersion' destroot/Library/Frameworks/iphoneos/hermes.framework/Info.plist 10.0 ~/t/package » /usr/libexec/PlistBuddy -c 'Print :LSMinimumSystemVersion' destroot/Library/Frameworks/macosx/hermes.framework/Resources/Info.plist 10.13 ``` Reviewed By: mhorowitz Differential Revision: D25839408 Pulled By: Huxpro fbshipit-source-id: 8067069d66ea3af36366157ffae95445e9e89392
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420
Summary
Apple App Store submission, at least the iOS one, requires this metadata to be specified when only targeting a subset of possible archs.
Test Plan